Core: Update constructor parameters for older DeleteFilter implementations #4394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
changed the title
stevenzwu
approved these changes
Mar 24, 2022
Member
|
Looks like #4381 broke the build and this fixes it? Though, confused how the initial pr passed the build |
szehon-ho
approved these changes
Mar 24, 2022
Member
|
Merging to try to fix the build, thanks for following up. |
Contributor
|
Thanks @szehon-ho I'm not sure what happened with CI (maybe I missed it), but I didn't see failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the older modules when doing this update #4381
@stevenzwu @danielcweeks